[ 
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881424#comment-15881424
 ] 

ASF GitHub Bot commented on FLINK-5767:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3354#discussion_r102835657
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MinAggFunction.scala
 ---
    @@ -31,7 +31,8 @@ abstract class MinAggFunction[T](implicit ord: 
Ordering[T]) extends AggregateFun
     
       /** The initial accumulator for Min aggregate function */
       class MinAccumulator[T] extends JTuple2[T, Boolean] with Accumulator {
    --- End diff --
    
    We can remove the type `T`


> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
>                 Key: FLINK-5767
>                 URL: https://issues.apache.org/jira/browse/FLINK-5767
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the 
> aggregate interface, migrating the existing aggregation functions to this 
> interface, and adding the unit tests for these functions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to