[
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881432#comment-15881432
]
ASF GitHub Bot commented on FLINK-5767:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102826382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunction.scala
---
@@ -41,24 +42,33 @@ abstract class MaxAggFunction[T](implicit ord:
Ordering[T]) extends AggregateFun
override def accumulate(accumulator: Accumulator, value: Any) = {
if (value != null) {
val v = value.asInstanceOf[T]
- val accum = accumulator.asInstanceOf[MaxAccumulator[T]]
- if (accum.max == null || ord.compare(accum.max, v) < 0) {
- accum.max = v
+ val a = accumulator.asInstanceOf[MaxAccumulator[T]]
+ if (!a.f1 || ord.compare(a.f0, v) < 0) {
+ a.f0 = v
+ if (!a.f1) {
--- End diff --
the condition can be removed. We can simply reassign `true`.
> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
> Key: FLINK-5767
> URL: https://issues.apache.org/jira/browse/FLINK-5767
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the
> aggregate interface, migrating the existing aggregation functions to this
> interface, and adding the unit tests for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
