[
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881423#comment-15881423
]
ASF GitHub Bot commented on FLINK-5767:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102835493
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SumAggFunction.scala
---
@@ -32,7 +31,8 @@ abstract class SumAggFunction[T: Numeric] extends
AggregateFunction[T] {
/** The initial accumulator for Sum aggregate function */
class SumAccumulator[T] extends JTuple2[T, Boolean] with Accumulator {
- var sum: T = null.asInstanceOf[T]
+ f0 = 0.asInstanceOf[T] //sum
--- End diff --
change this to `f0 = numeric.zero`
> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
> Key: FLINK-5767
> URL: https://issues.apache.org/jira/browse/FLINK-5767
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the
> aggregate interface, migrating the existing aggregation functions to this
> interface, and adding the unit tests for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
