[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885051#comment-15885051
]
ASF GitHub Bot commented on FLINK-5791:
---------------------------------------
Github user shuai-xu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r103129000
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -198,9 +197,9 @@ public static TaskManagerServices fromConfiguration(
final FileCache fileCache = new
FileCache(taskManagerServicesConfiguration.getTmpDirPaths());
- final List<ResourceProfile> resourceProfiles = new
ArrayList<>(taskManagerServicesConfiguration.getNumberOfSlots());
+ final List<ResourceProfile> resourceProfiles =
taskManagerServicesConfiguration.getResourceProfiles();
- for (int i = 0; i <
taskManagerServicesConfiguration.getNumberOfSlots(); i++) {
+ for (int i = resourceProfiles.size(); i <
taskManagerServicesConfiguration.getNumberOfSlots(); i++) {
resourceProfiles.add(new ResourceProfile(1.0, 42L));
--- End diff --
Now only yarn resource manager will add resource profiles in the config,
for standalone, there are none. so the resourceProfiles.size() will be zero,
still need to add a ResourceProfile here. I think adding one can match all
other resource profile is a good idea, I will introduce it.
> Resource should be strictly matched when allocating for yarn
> ------------------------------------------------------------
>
> Key: FLINK-5791
> URL: https://issues.apache.org/jira/browse/FLINK-5791
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> In flip6, for yarn mode, resource should be assigned as requested to avoid
> resource wasting and OOM.
> 1. YarnResourceManager will request container according to ResourceProfile
> in slot request form JM.
> 2. RM will pass the ResourceProfile to TM for initializing its slots.
> 3. RM should match the slots offered by TM with SlotRequest from JM strictly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
