[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894462#comment-15894462
]
ASF GitHub Bot commented on FLINK-5791:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r104161807
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -119,6 +122,9 @@ public boolean equals(Object obj) {
}
else if (obj != null && obj.getClass() ==
ResourceProfile.class) {
ResourceProfile that = (ResourceProfile) obj;
+ if (this == ResourceProfile.UNIVERSAL || that ==
ResourceProfile.UNIVERSAL) {
+ return true;
+ }
--- End diff --
The contract of the universal slot should not be reflected via the `equals`
method of an `Object`. This is highly dangerous.
> Resource should be strictly matched when allocating for yarn
> ------------------------------------------------------------
>
> Key: FLINK-5791
> URL: https://issues.apache.org/jira/browse/FLINK-5791
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> In flip6, for yarn mode, resource should be assigned as requested to avoid
> resource wasting and OOM.
> 1. YarnResourceManager will request container according to ResourceProfile
> in slot request form JM.
> 2. RM will pass the ResourceProfile to TM for initializing its slots.
> 3. RM should match the slots offered by TM with SlotRequest from JM strictly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
