[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894419#comment-15894419
]
ASF GitHub Bot commented on FLINK-5791:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r104158582
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -245,7 +248,7 @@ public void onContainersAllocated(List<Container>
containers) {
try {
/** Context information used to start a
TaskExecutor Java process */
ContainerLaunchContext
taskExecutorLaunchContext =
-
createTaskExecutorLaunchContext(container.getResource(),
container.getId().toString(), container.getNodeId().getHost());
+
createTaskExecutorLaunchContext(container.getResource(),
container.getId().toString(), container.getNodeId().getHost(),
container.getPriority());
--- End diff --
Yes, but this should not be a problem. I think the resource manager should
be able to deal with this kind of scenario. For example, if the allocated
container offers more resources than requested, it could in the future also be
used to fulfill other slot request which require more resources.
> Resource should be strictly matched when allocating for yarn
> ------------------------------------------------------------
>
> Key: FLINK-5791
> URL: https://issues.apache.org/jira/browse/FLINK-5791
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> In flip6, for yarn mode, resource should be assigned as requested to avoid
> resource wasting and OOM.
> 1. YarnResourceManager will request container according to ResourceProfile
> in slot request form JM.
> 2. RM will pass the ResourceProfile to TM for initializing its slots.
> 3. RM should match the slots offered by TM with SlotRequest from JM strictly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
