[ 
https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956216#comment-15956216
 ] 

ASF GitHub Bot commented on FLINK-4953:
---------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3661#discussion_r109821341
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
 ---
    @@ -2560,7 +2560,7 @@ public int compare(Object o1, Object o2) {
                                        if (comparison != 0) {
                                                return comparison;
                                        }
    -                                   return (int) (sr0.getValue().f1 - 
sr1.getValue().f1);
    +                                   return (int) (sr0.getValue().f2 - 
sr1.getValue().f2);
    --- End diff --
    
    @aljoscha this line compares second field again rather than the third field.


> Allow access to "time" in ProcessWindowFunction.Context
> -------------------------------------------------------
>
>                 Key: FLINK-4953
>                 URL: https://issues.apache.org/jira/browse/FLINK-4953
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The recently added {{ProcessWindowFunction}} has a {{Context}} object that 
> allows querying some additional information about the window firing that we 
> are processing. Right now, this is only the window for which the firing is 
> happening. We should extends this with methods that allow querying the 
> current processing time and the current watermark.
> Original text by issue creator: This is similar to FLINK-3674 but exposing 
> time information in window functions. Currently when a timer is fired, all 
> states in a window will be returned to users, including those after the 
> timer. This change will allow users to filter out states after the timer 
> based on time info.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to