[
https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953439#comment-15953439
]
ASF GitHub Bot commented on FLINK-4953:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3661
Thanks for opening this PR. 😃
I had a few comments and I think it's easier to collect them here instead
of commenting on the individual files:
- I would prefer to not call `context.getCurrent*Time()` overtime even
though it's not needed. This can be costly. Instead we can pass the `Context`
and only invoke the methods when needed.
- I regard `WindowOperatorTest` as legacy, new tests should be added to
`WindowOperatorContractTest`. This is a base class with a lot of test cases
that is extended by `RegularWindowOperatorTest` and
`EvictingWindowOperatorTest`.
Both of these are hard to know and it's not obvious what test should go
where, sorry for the inconvenience.
> Allow access to "time" in ProcessWindowFunction.Context
> -------------------------------------------------------
>
> Key: FLINK-4953
> URL: https://issues.apache.org/jira/browse/FLINK-4953
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Manu Zhang
> Assignee: Manu Zhang
>
> The recently added {{ProcessWindowFunction}} has a {{Context}} object that
> allows querying some additional information about the window firing that we
> are processing. Right now, this is only the window for which the firing is
> happening. We should extends this with methods that allow querying the
> current processing time and the current watermark.
> Original text by issue creator: This is similar to FLINK-3674 but exposing
> time information in window functions. Currently when a timer is fired, all
> states in a window will be returned to users, including those after the
> timer. This change will allow users to filter out states after the timer
> based on time info.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
