[
https://issues.apache.org/jira/browse/FLINK-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078071#comment-14078071
]
ASF GitHub Bot commented on FLINK-1023:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/84#issuecomment-50512992
Very nice change!
While reading through the examples, I was wondering if it would make sense
to throw an exception if the user is trying to create a second iterator(). Or
maybe an exception if hasNext() == false and the user wants to create a second
iterator.
I don't know if a) there are usecases for creating two iterators
and b) users will be confused by the behavior (similar to the mutable
objects)
In addition to that, we should copy the nicely written comment of the pull
request into the documentation.
> Provide Iterable instead of Iterator to grouped functions
> ---------------------------------------------------------
>
> Key: FLINK-1023
> URL: https://issues.apache.org/jira/browse/FLINK-1023
> Project: Flink
> Issue Type: Wish
> Components: Java API
> Reporter: Ufuk Celebi
> Priority: Trivial
> Labels: breaking-api
>
> I would like the grouped functions to provide an Iterable instead of an
> Iterator to the user, e.g. for the {{reduce}} method of
> {{GroupReduceFunction}}.
> We had a discussion about this previously (I couldn't find the respective
> issues/list threads right now) and the result was in favor of the change.
> We never got around to really push for it, because of the API break. With the
> renaming, it should be less of an issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
