[
https://issues.apache.org/jira/browse/FLINK-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078316#comment-14078316
]
ASF GitHub Bot commented on FLINK-1023:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/84#issuecomment-50535230
I think throwing a meaningful exception when accessing the iterator a
second time is the more intuitive and user-friendly option. I think it is
easier to get a function right, if an exception explicitly tells you what you
are doing wrong rather than debugging the code and wondering why the stupid
iterator is empty...
+1 to throw an exception when the iterator is requested the second time.
> Provide Iterable instead of Iterator to grouped functions
> ---------------------------------------------------------
>
> Key: FLINK-1023
> URL: https://issues.apache.org/jira/browse/FLINK-1023
> Project: Flink
> Issue Type: Wish
> Components: Java API
> Reporter: Ufuk Celebi
> Priority: Trivial
> Labels: breaking-api
>
> I would like the grouped functions to provide an Iterable instead of an
> Iterator to the user, e.g. for the {{reduce}} method of
> {{GroupReduceFunction}}.
> We had a discussion about this previously (I couldn't find the respective
> issues/list threads right now) and the result was in favor of the change.
> We never got around to really push for it, because of the API break. With the
> renaming, it should be less of an issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
