[
https://issues.apache.org/jira/browse/FLINK-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079171#comment-14079171
]
ASF GitHub Bot commented on FLINK-1023:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/incubator-flink/pull/84#issuecomment-50600322
i feel like we are going in circles^^
take the ```IterableIterator``` class, rename it to ```Iterator```, add
into docu/javadocs "Iterator on which the for-each statement can be used. the
for-each loop starts at the element that next() would return".
traversable-once characteristic is obvious, supports for-each statement,
solves these odd exception issues andd the differences to a normal iterator can
be summed up in 2 lines. bonus: less API breaking, since its just an import
that has to be changed.
we cant use a name that makes all properties obvious (because
```IterableIterator``` is an odd name). the for-each statement not being
obviously usable is imo a lot more desirable than then user creating faulty
programs hitting exceptions based on false premises how the ```Iterable```works.
> Provide Iterable instead of Iterator to grouped functions
> ---------------------------------------------------------
>
> Key: FLINK-1023
> URL: https://issues.apache.org/jira/browse/FLINK-1023
> Project: Flink
> Issue Type: Wish
> Components: Java API
> Reporter: Ufuk Celebi
> Priority: Trivial
> Labels: breaking-api
>
> I would like the grouped functions to provide an Iterable instead of an
> Iterator to the user, e.g. for the {{reduce}} method of
> {{GroupReduceFunction}}.
> We had a discussion about this previously (I couldn't find the respective
> issues/list threads right now) and the result was in favor of the change.
> We never got around to really push for it, because of the API break. With the
> renaming, it should be less of an issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
