[
https://issues.apache.org/jira/browse/GEODE-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304638#comment-16304638
]
ASF GitHub Bot commented on GEODE-4163:
---------------------------------------
bschuchardt opened a new pull request #1206: GEODE-4163 clean up
DistributionManager code
URL: https://github.com/apache/geode/pull/1206
Removed all dead code - about 800 lines of code have been removed.
Removed DistributionChannel, which served no useful purpose.
Made many methods private or package-private.
Gathered most statics and instance variables scattered around in the file
and moved them to the top.
I attempted to replace use of InternalDistributedMember with
DistributedMember but the use of the former is too widespread. If we
want to do that it will change a large set of files.
@upthewaterspout @WireBaron @galen-pivotal @PivotalSarge
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> clean up DistributionManager code
> ---------------------------------
>
> Key: GEODE-4163
> URL: https://issues.apache.org/jira/browse/GEODE-4163
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Bruce Schuchardt
>
> DistributionManager has a large number of methods that are marked public but
> should be private.
> It has a lot of methods and instance variables that aren't used and a lot of
> commented-out code.
> There are also other classes that cast a DM to DistributionManager in order
> to use methods marked public instead of adding those methods to the DM
> interface.
> DistributionManager also has instance variable sprinkled throughout the file
> and lots of raw, untyped collections.
> There are also a lot of methods that have InternalDistributedMember in their
> signatures that were extracted into the DM interface. These should be
> changed to DistributedMember, the interface that most of our code should use.
> All of these problems should be fixed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
