[ https://issues.apache.org/jira/browse/GEODE-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306376#comment-16306376 ]
ASF subversion and git services commented on GEODE-4163: -------------------------------------------------------- Commit e2cdaa7d825500920bec892ffac240e6d91db698 in geode's branch refs/heads/develop from [~bschuchardt] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e2cdaa7 ] GEODE-4163 clean up DistributionManager code removing lingering references to the deleted class DistributionChannel > clean up DistributionManager code > --------------------------------- > > Key: GEODE-4163 > URL: https://issues.apache.org/jira/browse/GEODE-4163 > Project: Geode > Issue Type: Bug > Components: membership > Reporter: Bruce Schuchardt > Fix For: 1.4.0 > > > DistributionManager has a large number of methods that are marked public but > should be private. > It has a lot of methods and instance variables that aren't used and a lot of > commented-out code. > There are also other classes that cast a DM to DistributionManager in order > to use methods marked public instead of adding those methods to the DM > interface. > DistributionManager also has instance variable sprinkled throughout the file > and lots of raw, untyped collections. > There are also a lot of methods that have InternalDistributedMember in their > signatures that were extracted into the DM interface. These should be > changed to DistributedMember, the interface that most of our code should use. > All of these problems should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)