[ https://issues.apache.org/jira/browse/GEODE-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304955#comment-16304955 ]
ASF subversion and git services commented on GEODE-4163: -------------------------------------------------------- Commit 3be095af2baf90e7c2f2ee68c860031590bf944c in geode's branch refs/heads/develop from [~bschuchardt] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3be095a ] GEODE-4163 clean up DistributionManager code Removed all dead code - about 800 lines of code have been removed. Removed DistributionChannel, which served no useful purpose. Made many methods private or package-private. Gathered most statics and instance variables scattered around in the file and moved them to the top. I attempted to replace use of InternalDistributedMember with DistributedMember but the use of the former is too widespread. If we want to do that it will change a large set of files. This closes #1206 > clean up DistributionManager code > --------------------------------- > > Key: GEODE-4163 > URL: https://issues.apache.org/jira/browse/GEODE-4163 > Project: Geode > Issue Type: Bug > Components: membership > Reporter: Bruce Schuchardt > > DistributionManager has a large number of methods that are marked public but > should be private. > It has a lot of methods and instance variables that aren't used and a lot of > commented-out code. > There are also other classes that cast a DM to DistributionManager in order > to use methods marked public instead of adding those methods to the DM > interface. > DistributionManager also has instance variable sprinkled throughout the file > and lots of raw, untyped collections. > There are also a lot of methods that have InternalDistributedMember in their > signatures that were extracted into the DM interface. These should be > changed to DistributedMember, the interface that most of our code should use. > All of these problems should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)