[
https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272372#comment-17272372
]
ASF GitHub Bot commented on GEODE-8870:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564796154
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/DiskInitFileParser.java
##########
@@ -469,15 +465,15 @@ public DiskStoreID parse() throws IOException,
ClassNotFoundException {
readEndOfRecord(dis);
if (logger.isTraceEnabled(LogMarker.PERSIST_RECOVERY_VERBOSE)) {
logger.trace(LogMarker.PERSIST_RECOVERY_VERBOSE,
- "IFREC_REVOKE_DISK_STORE_ID id={}" + pattern);
+ "IFREC_REVOKE_DISK_STORE_ID id={}", pattern);
}
interpreter.cmnRevokeDiskStoreId(pattern);
}
break;
default:
throw new DiskAccessException(
String.format("Unknown opCode %s found in disk initialization
file.", opCode),
- this.interpreter.getNameForError());
+ interpreter.getNameForError());
Review comment:
If it is redundant it is noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove obsolete version compatibility code
> ------------------------------------------
>
> Key: GEODE-8870
> URL: https://issues.apache.org/jira/browse/GEODE-8870
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> As a followup to GEODE-8837 remove all obsolete backwards compatibility code.
> This ticket will catch all changes to remove the obsolete code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
