[
https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272391#comment-17272391
]
ASF GitHub Bot commented on GEODE-8870:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564807907
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/SocketMessageWriter.java
##########
@@ -45,46 +47,41 @@ public void writeHandshakeMessage(DataOutputStream dos,
byte type, String p_msg,
msg = "";
}
dos.writeUTF(msg);
- if (clientVersion != null &&
clientVersion.isNotOlderThan(KnownVersion.GFE_61)) {
- // get all the instantiators.
- Instantiator[] instantiators = InternalInstantiator.getInstantiators();
- HashMap instantiatorMap = new HashMap();
- if (instantiators != null && instantiators.length > 0) {
- for (Instantiator instantiator : instantiators) {
- ArrayList instantiatorAttributes = new ArrayList();
-
instantiatorAttributes.add(instantiator.getClass().toString().substring(6));
-
instantiatorAttributes.add(instantiator.getInstantiatedClass().toString().substring(6));
- instantiatorMap.put(instantiator.getId(), instantiatorAttributes);
- }
+
Review comment:
Even there though, the clients expecting this `int` will get pretty
upset if they don't get it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove obsolete version compatibility code
> ------------------------------------------
>
> Key: GEODE-8870
> URL: https://issues.apache.org/jira/browse/GEODE-8870
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> As a followup to GEODE-8837 remove all obsolete backwards compatibility code.
> This ticket will catch all changes to remove the obsolete code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
