[
https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272383#comment-17272383
]
ASF GitHub Bot commented on GEODE-8870:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564800222
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
##########
@@ -665,16 +663,8 @@ private ServerConnectionCollection
getProxyIdCollection(ClientProxyMembershipID
return cleanupTable;
}
- private int getNumberOfClientsAtOrAboveVersion(KnownVersion version) {
- int number = 0;
- for (int i = version.ordinal(); i < numOfClientsPerVersion.length(); i++) {
- number += numOfClientsPerVersion.get(i);
- }
- return number;
- }
-
public boolean hasDeltaClients() {
- return getNumberOfClientsAtOrAboveVersion(KnownVersion.GFE_61) > 0;
+ return numberOfClientsWithConflationOff.get() > 0;
Review comment:
Yes, seems odd we track the number. I wonder if there is really any
savings by this complexity. Outside my scope but at least now it is obvious
what this counter is for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove obsolete version compatibility code
> ------------------------------------------
>
> Key: GEODE-8870
> URL: https://issues.apache.org/jira/browse/GEODE-8870
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> As a followup to GEODE-8837 remove all obsolete backwards compatibility code.
> This ticket will catch all changes to remove the obsolete code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
