[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

[huor]

Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437352
  
    --- Diff: src/backend/commands/tablecmds.c ---
    @@ -17845,14 +18448,16 @@ static Datum transformFormatOpts(char formattype, 
List *formatOpts, int numcols,
     
        Assert(fmttype_is_custom(formattype) || 
                   fmttype_is_text(formattype) ||
    -              fmttype_is_csv(formattype));
    +              fmttype_is_csv(formattype) ||
    --- End diff --
    
    The check of format options should not be hard coded.


---