[
https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714732#comment-13714732
]
Lars George commented on HBASE-8947:
------------------------------------
Hi [~madani], I have two issues here, first a simple one: in hbase.thrift you
have under "Specify Durability" twice SKIP_WAL, where for one you meant write
SYNC_WAL.
The more major issue I have is that the patch as it is is breaking
compatibility. We should add TDurability, but not replace writeToWAL. In other
words, keep the existing, add the new with a new index, and then in the code
use isSetDurability() to check if the client is using it and prefer it over the
existing Boolean. In case the existing Boolean is used, use the
isSetWriteToWAL() and translate it into the SYNC_WAL or SKIP_WAL durability
value as needed. Make sense?
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability"
> -------------------------------------------------------------------
>
> Key: HBASE-8947
> URL: https://issues.apache.org/jira/browse/HBASE-8947
> Project: HBase
> Issue Type: Sub-task
> Components: Thrift
> Reporter: Hamed Madani
> Assignee: Hamed Madani
> Attachments: HBASE-8947.patch, HBASE-8947-v2.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.*
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
