[
https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714794#comment-13714794
]
Lars George commented on HBASE-8947:
------------------------------------
Good question on where to drop this, we would need to deprecate it first. I
suggest we follow Mutation and setDurability(), which deprecated
setWriteToWAL() in 0.94 and dropped it in 0.95 and trunk.
Well, with the default of writeToWAL, I thought if we first check if
isSetDurability() we favor it over the old setWriteToWAL, then default or not
it is ignore. We should also set a default for TDurability though:
{code}
/**
* If this is for tables durability, use HBase's global default value
(SYNC_WAL).
* Otherwise, if this is for mutation, use the table's default setting to
determine durability.
* This must remain the first option.
*/
USE_DEFAULT,
{code}
This is from the Durability.java class. Can we somehow derive this on the
Thrift side? I guess we can add a TDurability.USE_DEFAULT, make it the default
and then pass it on?
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability"
> -------------------------------------------------------------------
>
> Key: HBASE-8947
> URL: https://issues.apache.org/jira/browse/HBASE-8947
> Project: HBase
> Issue Type: Sub-task
> Components: Thrift
> Reporter: Hamed Madani
> Assignee: Hamed Madani
> Attachments: HBASE-8947.patch, HBASE-8947-v2.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.*
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
