[ 
https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714790#comment-13714790
 ] 

Hamed Madani commented on HBASE-8947:
-------------------------------------

Made this patch late at night. Thanks for reviewing it [~larsgeorge]. I can 
certainly bring back *writeToWAL* for backwards compatibility. Do we want to 
keep this backward compatibility with 0.95 and 0.98 ? or only 0.94 ? 

Also currently, writeToWal defaults to true when it's not set by user which 
will translate to "Durability.SYNC_WAL". If we were to keep *writeToWAL* I 
suggest we remove the default value, so we can set Durability only when 
writeToWal or TDurability is explicitly set and otherwise default to CF 
Durability setting. What do you think ?
                
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability" 
> -------------------------------------------------------------------
>
>                 Key: HBASE-8947
>                 URL: https://issues.apache.org/jira/browse/HBASE-8947
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE-8947.patch, HBASE-8947-v2.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.* 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to