[
https://issues.apache.org/jira/browse/HBASE-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115061#comment-13115061
]
Jesse Yates commented on HBASE-4448:
------------------------------------
Quick synopsis:
re:re: #1
So you are thinking that people would just the TestingUtility if they need to
have their own unique cluster? I guess I was thinking that there would be a
gain by reusing those objects, but thinking about it, I doubt it (also thinking
everything would be brokered by the Factory, but it really needn't).
Also was thinking we need to do a review of mini-cluster usage on things like
REST - had the same hunch when I was grepping through the tests.
re:re #2
+1
re:re #3
I don't think this actually runs multiple times - run() just has a try method
and won't loop.
I'm ok with making it simple right now, lets just make a note to complicate it
later ;)
Overall, I'm ok with it, except for the looping in #3
> HBaseTestingUtilityFactory - pattern for re-using HBaseTestingUtility
> instances across unit tests
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4448
> URL: https://issues.apache.org/jira/browse/HBASE-4448
> Project: HBase
> Issue Type: Improvement
> Reporter: Doug Meil
> Assignee: Doug Meil
> Priority: Minor
> Attachments: HBaseTestingUtilityFactory.java,
> hbase_hbaseTestingUtility_uses_2011_09_22.xlsx, java_HBASE_4448.patch
>
>
> Setting up and tearing down HBaseTestingUtility instances in unit tests is
> very expensive. On my MacBook it takes about 10 seconds to set up a
> MiniCluster, and 7 seconds to tear it down. When multiplied by the number of
> test classes that use this facility, that's a lot of time in the build.
> This factory assumes that the JVM is being re-used across test classes in the
> build, otherwise this pattern won't work.
> I don't think this is appropriate for every use, but I think it can be
> applicable in a great many cases - especially where developers just want a
> simple MiniCluster with 1 slave.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
