[
https://issues.apache.org/jira/browse/HBASE-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115063#comment-13115063
]
Ted Yu commented on HBASE-4448:
-------------------------------
I haven't gone through every line of the patch.
Minor comment:
{code}
+ i = new Integer(ONE);
{code}
ONE is already an Integer, right ?
I wasn't involved in the early discussion of this ticket. So I hope Jesse and
Doug can reach agreement and create other tickets if needed.
If improvement in running time of tests by using the patch can be shown, that
would be more convincing.
> HBaseTestingUtilityFactory - pattern for re-using HBaseTestingUtility
> instances across unit tests
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4448
> URL: https://issues.apache.org/jira/browse/HBASE-4448
> Project: HBase
> Issue Type: Improvement
> Reporter: Doug Meil
> Assignee: Doug Meil
> Priority: Minor
> Attachments: HBaseTestingUtilityFactory.java,
> hbase_hbaseTestingUtility_uses_2011_09_22.xlsx, java_HBASE_4448.patch
>
>
> Setting up and tearing down HBaseTestingUtility instances in unit tests is
> very expensive. On my MacBook it takes about 10 seconds to set up a
> MiniCluster, and 7 seconds to tear it down. When multiplied by the number of
> test classes that use this facility, that's a lot of time in the build.
> This factory assumes that the JVM is being re-used across test classes in the
> build, otherwise this pattern won't work.
> I don't think this is appropriate for every use, but I think it can be
> applicable in a great many cases - especially where developers just want a
> simple MiniCluster with 1 slave.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
