[ https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005223#comment-15005223 ]
Ashish Singhi commented on HBASE-14769: --------------------------------------- [~appy], nice cleanup. One question, {{HBaseAdmin}} is marked for private audience and {{HBaseTestingUtility}} is marked as public. {{HBaseTestingUtility#getHBaseAdmin}} will return a {{HBaseAdmin}} object. Now since we have removed most of the(if not all) public apis in {{HBaseAdmin}} class which were taking table name as byte[] or String as argument which were not marked as deprecated only and some public apis marked as deprecated only in 2.0 version. Will it not break users using {{HBaseTestingUtility}} class from 1.x to 2.0 ? > Remove unused functions and duplicate javadocs from HBaseAdmin > --------------------------------------------------------------- > > Key: HBASE-14769 > URL: https://issues.apache.org/jira/browse/HBASE-14769 > Project: HBase > Issue Type: Bug > Reporter: Appy > Assignee: Appy > Attachments: HBASE-14769-master-v2.patch, > HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch, > HBASE-14769-master.patch > > > HBaseAdmin is marked private, so removing the functions not being used > anywhere. > Also, the javadocs of overridden functions are same as corresponding ones in > Admin.java. Since javadocs are automatically inherited from the interface > class, we can remove these redundant 100s of lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)