[ 
https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025649#comment-15025649
 ] 

Appy commented on HBASE-14769:
------------------------------

Yeah, that's an issue. Users getting HBaseAdmin and using public functions 
being removed here will break.

On other side, considering InterfaceAudience scope transitively will make 
things very difficult. Even though there is a function to return HBaseAdmin, 
users should be aware that it's a private and evolving class.

It's hard to decide what's right in such case. But given the functions being 
removed are long dead (we moved to TableName two years ago?) and the class 
itself is private, it should be alright. I agree with Sean though, mentioning 
clearly in HBTU that it only supports Admin interface. 
In addition i'll deprecate that function and add a function to return Admin 
object.

> Remove unused functions and duplicate javadocs from HBaseAdmin 
> ---------------------------------------------------------------
>
>                 Key: HBASE-14769
>                 URL: https://issues.apache.org/jira/browse/HBASE-14769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14769-master-v2.patch, 
> HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch, 
> HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used 
> anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in 
> Admin.java. Since javadocs are automatically inherited from the interface 
> class, we can remove these redundant 100s of lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to