[ 
https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025590#comment-15025590
 ] 

Sean Busbey commented on HBASE-14769:
-------------------------------------

on this point:

{quote}
v4: fixing checkstyle errors.
Hudson will very likely still report +3 checkstyle errors of type 
"MissingDeprecated    Must include both @java.lang.Deprecated annotation and 
@deprecated Javadoc tag with description". But that's because of removing 
comments since parent function already contains deprecated tag too. Is it 
alright?
{quote}

I'd say repeat the javadoc with deprecation in case the person creating hte 
javadocs hasn't configured things to show inherited javadocs.

> Remove unused functions and duplicate javadocs from HBaseAdmin 
> ---------------------------------------------------------------
>
>                 Key: HBASE-14769
>                 URL: https://issues.apache.org/jira/browse/HBASE-14769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-14769-master-v2.patch, 
> HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch, 
> HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used 
> anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in 
> Admin.java. Since javadocs are automatically inherited from the interface 
> class, we can remove these redundant 100s of lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to