[
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286269#comment-16286269
]
Ted Yu commented on HBASE-19483:
--------------------------------
Looks good overall.
{code}
+ * Called before get rsgroup info for given group name
+ * @param ctx the environment to interact with the framework and master
+ */
+ default void preGetRSGroupInfo(final
ObserverContext<MasterCoprocessorEnvironment> ctx,
+ final String groupName) throws IOException {}
{code}
nit: add @param for groupName (please check other new hooks as well).
> Add proper privilege check for rsgroup commands
> -----------------------------------------------
>
> Key: HBASE-19483
> URL: https://issues.apache.org/jira/browse/HBASE-19483
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Guangxu Cheng
> Attachments: HBASE-19483.master.001.patch
>
>
> Currently list_rsgroups command can be executed by any user.
> This is inconsistent with other list commands such as list_peers and
> list_peer_configs.
> We should add proper privilege check for list_rsgroups command.
> privilege check should be added for get_table_rsgroup / get_server_rsgroup /
> get_rsgroup commands.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
