[ https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287199#comment-16287199 ]
Guangxu Cheng commented on HBASE-19483: --------------------------------------- {quote} Review: Add documentation in hbase book. RS Group section should talk about permissions too. post*() hooks are more useful if they also pass the result as a param. For eg. postListRSGroup() should be postListRSGroup(List<RSGroupInfo>). Similarly others. {quote} I will add documentation and pass the result. bq.Bigger questions than this change, no need to block patch on this. Can be done in separate jiras: I will create a new jira later to solve these problems. Thanks [~appy] for view. > Add proper privilege check for rsgroup commands > ----------------------------------------------- > > Key: HBASE-19483 > URL: https://issues.apache.org/jira/browse/HBASE-19483 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Guangxu Cheng > Attachments: HBASE-19483.master.001.patch > > > Currently list_rsgroups command can be executed by any user. > This is inconsistent with other list commands such as list_peers and > list_peer_configs. > We should add proper privilege check for list_rsgroups command. > privilege check should be added for get_table_rsgroup / get_server_rsgroup / > get_rsgroup commands. -- This message was sent by Atlassian JIRA (v6.4.14#64029)