[ 
https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288454#comment-16288454
 ] 

Appy commented on HBASE-19483:
------------------------------

bq. @param rsGroupInfo the group information
It'd be nice to have javadocs give more information than what the parameter 
name already conveys. "rsGroupInfo" already says that it's group information.
The right javadoc would be something like "RSGroupInfo to which the given table 
belongs." . Additionally, if they can be null, etc.
(We all need to get better at javadocs as a community, just trying to promote 
the change. Please look for same in your reviews :-))




> Add proper privilege check for rsgroup commands
> -----------------------------------------------
>
>                 Key: HBASE-19483
>                 URL: https://issues.apache.org/jira/browse/HBASE-19483
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Guangxu Cheng
>         Attachments: HBASE-19483.master.001.patch, 
> HBASE-19483.master.002.patch
>
>
> Currently list_rsgroups command can be executed by any user.
> This is inconsistent with other list commands such as list_peers and 
> list_peer_configs.
> We should add proper privilege check for list_rsgroups command.
> privilege check should be added for get_table_rsgroup / get_server_rsgroup / 
> get_rsgroup commands.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to