[ 
https://issues.apache.org/jira/browse/HBASE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222173#comment-13222173
 ] 

Himanshu Vashishtha commented on HBASE-4348:
--------------------------------------------

I have some some analysis and some questions regarding the metrics here. Please 
correct me if I am wrong.

RegionServer updates its metrics at fix intervals defined by 
"hbase.regionserver.msginterval" and the metrics are pushed to the record after 
specified interval. 
Master don't use this methodology; rather whenever the master statistics are 
changed, the caller is supposed to update the metrics value on its own.

I am wondering why we don't follow the same approach for master (because the 
stats we are recording are not changing that often?). The reason I am asking is 
because the regionsInTransition map is mutated at bunch of places in the 
AssignmentManager class; so either I should invoke the method to compute and 
push the stats at all such callstacks, or may be we can have a similar approach 
as used by RegionServer.
                
> Add metrics for regions in transition
> -------------------------------------
>
>                 Key: HBASE-4348
>                 URL: https://issues.apache.org/jira/browse/HBASE-4348
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Himanshu Vashishtha
>            Priority: Minor
>              Labels: noob
>         Attachments: 4348-v1.patch, 4348-v2.patch, RITs.png
>
>
> The following metrics would be useful for monitoring the master:
> - the number of regions in transition
> - the number of regions in transition that have been in transition for more 
> than a minute
> - how many seconds has the oldest region-in-transition been in transition

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to