[
https://issues.apache.org/jira/browse/HBASE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232911#comment-13232911
]
jirapos...@reviews.apache.org commented on HBASE-4348:
------------------------------------------------------
bq. On 2012-03-19 19:05:08, Gregory Chanan wrote:
bq. > Looks pretty good, just some spacing issues.
bq. >
bq. > Are we sure that 60 seconds is the proper timeout to display
"interesting" regions in transition? Perhaps we should make this configurable?
(If yes, I'd also create a master msgInterval instead of reusing the
regionserver one).
bq.
bq. Himanshu Vashishtha wrote:
bq. Thanks for the review. I will make these changes and revise the patch.
Note that 60 seconds thing is actually used from the jira description, and is
not using any property as such. I can make this configurable though.
The region server property (hbase.regionserver.msginterval, default is 3 sec)
which i used is for the frequency for emitting out the metrics. Should that be
different for Master and RS?
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4402/#review6076
-----------------------------------------------------------
On 2012-03-19 06:48:19, Himanshu Vashishtha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4402/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-19 06:48:19)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch is for addinf Region in transition metrics to the HMaster
metrics system. It also adds these metrics in the master ui, in the Region in
transition section. I have attached the proposed new format in the jira 4348.
bq.
bq.
bq. This addresses bug HBase-4348.
bq. https://issues.apache.org/jira/browse/HBase-4348
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon
0dc0691
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
ae468ca
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java c4b4d30
bq. src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java
83abc52
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
d68ce33
bq.
bq. Diff: https://reviews.apache.org/r/4402/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran on a 5 node cluster and kill region servers randomly to observe the
changes in the RIT metrics as emitted out by the Master's mxbean;
bq.
bq. mvn test passes without any failure.
bq.
bq.
bq. Thanks,
bq.
bq. Himanshu
bq.
bq.
> Add metrics for regions in transition
> -------------------------------------
>
> Key: HBASE-4348
> URL: https://issues.apache.org/jira/browse/HBASE-4348
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Himanshu Vashishtha
> Priority: Minor
> Labels: noob
> Attachments: 4348-metrics-v3.patch, 4348-v1.patch, 4348-v2.patch,
> RITs.png, RegionInTransitions2.png, metrics-v2.patch
>
>
> The following metrics would be useful for monitoring the master:
> - the number of regions in transition
> - the number of regions in transition that have been in transition for more
> than a minute
> - how many seconds has the oldest region-in-transition been in transition
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
