[
https://issues.apache.org/jira/browse/HBASE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229605#comment-13229605
]
Jonathan Hsieh commented on HBASE-4348:
---------------------------------------
@Himanshu
My guess is it is a perf thing -- regionserver metrics include gets and puts
which can be costly to count efficiently and are using a special counter
library (and are thus not incremented using the hadoop Metrics library's
methods). While we want these RIT metrics, I don't think performance of the
counters on RIT's is something we need to worry about.
I have some suggestions and a handful of nits from just looking at the v3 patch.
Suggestions:
* I think you may need to do pushMetric(metricsRecord) on the new metrics in
the doUpdates method to "publish" the values?
* Previous versions had tests but this does not - plesae add tests or combine
into a single patch for review?
* Maybe use reviews.apache.org to make it easier to do reviews?
nits:
* There were some typos in the last line of the png file. please check/fix
spelling!
> Add metrics for regions in transition
> -------------------------------------
>
> Key: HBASE-4348
> URL: https://issues.apache.org/jira/browse/HBASE-4348
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Himanshu Vashishtha
> Priority: Minor
> Labels: noob
> Attachments: 4348-metrics-v3.patch, 4348-v1.patch, 4348-v2.patch,
> RITs.png, metrics-v2.patch
>
>
> The following metrics would be useful for monitoring the master:
> - the number of regions in transition
> - the number of regions in transition that have been in transition for more
> than a minute
> - how many seconds has the oldest region-in-transition been in transition
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
