[
https://issues.apache.org/jira/browse/HBASE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241330#comment-13241330
]
jirapos...@reviews.apache.org commented on HBASE-4348:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4402/
-----------------------------------------------------------
(Updated 2012-03-29 15:57:19.858937)
Review request for hbase.
Changes
-------
changes done as per Jon's feedback.
The access to MasterMetrics instance in the AssignmentManager class is guarded
by a null check.
Summary
-------
This patch is for adding Region in transition metrics to the HMaster metrics
system. It also adds these metrics in the master ui, in the Region in
transition section. I have attached the proposed new format in the jira 4348.
This addresses bug HBase-4348.
https://issues.apache.org/jira/browse/HBase-4348
Diffs (updated)
-----
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon
0dc0691
src/main/java/org/apache/hadoop/hbase/HConstants.java 19be4de
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ae468ca
src/main/java/org/apache/hadoop/hbase/master/HMaster.java c4b4d30
src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java
83abc52
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
d68ce33
Diff: https://reviews.apache.org/r/4402/diff
Testing
-------
Ran on a 5 node cluster and kill region servers randomly to observe the changes
in the RIT metrics as emitted out by the Master's mxbean;
mvn test passes without any failure.
Thanks,
Himanshu
> Add metrics for regions in transition
> -------------------------------------
>
> Key: HBASE-4348
> URL: https://issues.apache.org/jira/browse/HBASE-4348
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Himanshu Vashishtha
> Priority: Minor
> Labels: noob
> Attachments: 4348-metrics-v3.patch, 4348-v1.patch, 4348-v2.patch,
> RITs.png, RegionInTransitions2.png, metrics-v2.patch
>
>
> The following metrics would be useful for monitoring the master:
> - the number of regions in transition
> - the number of regions in transition that have been in transition for more
> than a minute
> - how many seconds has the oldest region-in-transition been in transition
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
