chenxu14 commented on a change in pull request #656: HBASE-23063 Add an option
to enable multiget in parallel
URL: https://github.com/apache/hbase/pull/656#discussion_r327998696
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -408,10 +411,10 @@ public void run() throws IOException {
* An RpcCallBack that creates a list of scanners that needs to perform
callBack operation on
* completion of multiGets.
*/
- static class RegionScannersCloseCallBack implements RpcCallback {
+ public static class RegionScannersCloseCallBack implements RpcCallback {
private final List<RegionScanner> scanners = new ArrayList<>();
- public void addScanner(RegionScanner scanner) {
+ public synchronized void addScanner(RegionScanner scanner) {
Review comment:
Because it may be called concurrently in different GetActionHandler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
