chenxu14 commented on a change in pull request #656: HBASE-23063 Add an option 
to enable multiget in parallel
URL: https://github.com/apache/hbase/pull/656#discussion_r328897238
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
 ##########
 @@ -969,6 +969,11 @@
   public static final String HBASE_REGION_SPLIT_POLICY_KEY =
     "hbase.regionserver.region.split.policy";
 
+  public static final String RS_PARALLEL_GET_ENABLED = 
"hbase.server.parallel.get.enabled";
+  public static final String RS_PARALLEL_GET_THREADS = 
"hbase.server.parallel.get.threads";
 
 Review comment:
   I think the feature is more suitable for low concurrent but high batch size 
scenarios(the number of multiget requests is small,  but the batch size of each 
multiget is very large).
   If the number of  RS Active handlers is larger than the capacity of the 
parallelGet threadpool, there should be performance degradation instead, So 
it's better not to enable it by default? 
   will explain this in releasenote.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to