chenxu14 commented on a change in pull request #656: HBASE-23063 Add an option to enable multiget in parallel URL: https://github.com/apache/hbase/pull/656#discussion_r328897001
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ########## @@ -969,6 +969,11 @@ public static final String HBASE_REGION_SPLIT_POLICY_KEY = "hbase.regionserver.region.split.policy"; + public static final String RS_PARALLEL_GET_ENABLED = "hbase.server.parallel.get.enabled"; + public static final String RS_PARALLEL_GET_THREADS = "hbase.server.parallel.get.threads"; Review comment: > Stats on executors for general RS sounds good. Need feedback to figure how to better make use of the feature. > > Add to release note stuff like '20 threads by default'. I'd be +1 for having it on by default but 20 seems like a high number. 5 threads by default? Since ExecutorService#getAllExecutorStatuses will return all executor’s status info, I think It‘s not difficult to collect them into metrics system, will track this in HBASE-23083 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services