ndimiduk commented on a change in pull request #781: HBASE-18095: Zookeeper-less client connection implementation URL: https://github.com/apache/hbase/pull/781#discussion_r344422192
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ########## @@ -3188,6 +3188,7 @@ public static String toLockJson(List<LockServiceProtos.LockedResource> lockedRes } public static HBaseProtos.RegionLocation toRegionLocation(HRegionLocation loc) { + if (loc == null) return null; Review comment: No, this is a code smell. Better the caller should filter `null` locations, or that they don't happen at all (see my comments in `MetaRegionLocationCache` re: storing `null` values in the cache. This method is also called by `ReopenTableRegionsProcedure`, so I am curious if there's a test that can exercise the `null` value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services