ndimiduk commented on a change in pull request #781: HBASE-18095: 
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r344421515
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/RegionReplicaTestHelper.java
 ##########
 @@ -89,6 +90,13 @@ static ServerName moveRegion(HBaseTestingUtility util, 
HRegionLocation currentLo
       .map(t -> t.getRegionServer().getServerName()).filter(sn -> 
!sn.equals(serverName)).findAny()
       .get();
     util.getAdmin().move(regionInfo.getEncodedNameAsBytes(), newServerName);
+    if (regionInfo.isMetaRegion()) {
+      // Invalidate the meta cache forcefully to avoid test races. Otherwise 
there might be a
 
 Review comment:
   Isn't this a scenario that can happen in real life, that we want the client 
code to handle gracefully? Why treat the test scenario specially?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to