virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371637044
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3818,6 +3828,40 @@ public ExecuteProceduresResponse
executeProcedures(RpcController controller,
}
}
+ @Override
+ @QosPriority(priority = HConstants.ADMIN_QOS)
+ public SlowLogResponses getSlowLogResponses(final RpcController controller,
+ final SlowLogResponseRequest request) throws ServiceException {
+ final OnlineSlowLogProvider onlineSlowLogProvider =
+ this.regionServer.getOnlineSlowLogProvider();
+ List<SlowLogPayload> slowLogPayloads;
+ if (onlineSlowLogProvider != null) {
+ slowLogPayloads = onlineSlowLogProvider.getSlowLogPayloads();
+ } else {
+ slowLogPayloads = new ArrayList<>();
+ }
+ SlowLogResponses slowLogResponses = SlowLogResponses.newBuilder()
+ .addAllSlowLogPayloads(slowLogPayloads)
+ .build();
+ return slowLogResponses;
+ }
+
+ @Override
+ @QosPriority(priority = HConstants.ADMIN_QOS)
+ public ClearSlowLogResponses clearSlowLogsResponses(final RpcController
controller,
+ final ClearSlowLogResponseRequest request) throws ServiceException {
+ final OnlineSlowLogProvider onlineSlowLogProvider =
+ this.regionServer.getOnlineSlowLogProvider();
+ boolean slowLogsCleaned = false;
Review comment:
Thanks for the suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
