virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371628695
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
##########
@@ -426,4 +437,55 @@ public void testAsyncTimeout() throws IOException {
rpcServer.stop();
}
}
+
+ @Test
Review comment:
I am actually looking for unit testing `rpcServer.logResponse()` which
ideally should land here, it's just that while testing this method, we are also
testing whether or not ringBuffer was filled up with records. Otherwise testing
void method would not be that straightforward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
