ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377245309
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/OnlineSlowLogProvider.java ########## @@ -0,0 +1,137 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.regionserver.slowlog; + +import com.lmax.disruptor.BlockingWaitStrategy; +import com.lmax.disruptor.RingBuffer; +import com.lmax.disruptor.dsl.Disruptor; +import com.lmax.disruptor.dsl.ProducerType; + +import java.util.Collections; +import java.util.List; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.util.Threads; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload; + +/** + * Online SlowLog Provider Service + */ +@InterfaceAudience.Private +@InterfaceStability.Evolving +public class OnlineSlowLogProvider { + + private final Disruptor<RingBufferTruck> disruptor; + private final SlowLogEventHandler slowLogEventHandler; + private final int eventCount; + private final boolean isOnlineSlowLogProviderEnabled; + + /** + * Initialize disruptor with configurable ringbuffer size + */ + public OnlineSlowLogProvider(Configuration conf) { + isOnlineSlowLogProviderEnabled = conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, + HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED); + + this.eventCount = conf.getInt(HConstants.SLOW_LOG_RING_BUFFER_SIZE, + HConstants.DEFAULT_SLOW_LOG_RING_BUFFER_SIZE); + + // This is the 'writer' -- a single threaded executor. This single thread consumes what is + // put on the ringbuffer. + final String hostingThreadName = Thread.currentThread().getName(); + + // disruptor initialization with BlockingWaitStrategy + this.disruptor = new Disruptor<>(RingBufferTruck::new, + getEventCount(), + Threads.newDaemonThreadFactory(hostingThreadName + ".append"), Review comment: Maybe include something to the effect of ".slowlog.append" so that it's not confused as a data-path append thread. I'm curious what the parent thread name ends up being... `"RS:0;localhost:xxxx"`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
