ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377235034
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ########## @@ -496,11 +518,51 @@ void logResponse(Message param, String methodName, String call, String tag, } } } - responseInfo.put("multi.gets", numGets); - responseInfo.put("multi.mutations", numMutations); - responseInfo.put("multi.servicecalls", numServiceCalls); + responseInfo.put(MULTI_GETS, numGets); + responseInfo.put(MULTI_MUTATIONS, numMutations); + responseInfo.put(MULTI_SERVICE_CALLS, numServiceCalls); } + final String tag = tooLarge ? "TooLarge" : "TooSlow"; Review comment: Again, "too large" and "too slow" are not mutually exclusive. Could be a message is logged with both tags, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services