ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377242097
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ########## @@ -590,6 +596,10 @@ public HRegionServer(final Configuration conf) throws IOException { this.abortRequested = false; this.stopped = false; + // initiate online slowlog ringbuffer only for RegionServers + if (!(this instanceof HMaster)) { Review comment: I agree that things are a bit of a mess currently. I was hoping that, with a little prodding, you might see an obvious better way ;) I agree that checking the instance type is better than `getProcessName`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services