ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377271382
########## File path: hbase-shell/src/main/ruby/hbase/admin.rb ########## @@ -1527,6 +1618,16 @@ def stop_master def stop_regionserver(hostport) @admin.stopRegionServer(hostport) end + + #---------------------------------------------------------------------------------------------- + # Get list of server names + def get_server_names(server_names) Review comment: nit: this is more of a `_to_java` kind of method. Reconsider the name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services