ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r377233563
########## File path: hbase-protocol-shaded/src/main/protobuf/TooSlowLog.proto ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = "proto2"; + +// This file contains protocol buffers that are used for Online TooSlowLogs +// To be used as Ring Buffer payload +package hbase.pb; + +option java_package = "org.apache.hadoop.hbase.shaded.protobuf.generated"; +option java_outer_classname = "TooSlowLog"; +option java_generate_equals_and_hash = true; +option optimize_for = SPEED; + +message SlowLogPayload { + required int64 start_time = 1; + required int32 processing_time = 2; + required int32 queue_time = 3; + required int64 response_size = 4; + required string client_address = 5; + required string server_class = 6; + required string method_name = 7; + required string call_details = 8; + required string param = 9; + required string user_name = 10; Review comment: So this POJO is used both for storing/serializing values and also as the query rpc filter params list? Maybe those two concerns should have two different payload objects... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
