busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch
default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409806498
##########
File path: bin/hbase-config.sh
##########
@@ -168,3 +168,27 @@ if [ -z "$JAVA_HOME" ]; then
EOF
exit 1
fi
+
+function read_java_version() {
+ properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
+ #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
Review comment:
nit, but this usually means we didn't tell shellcheck how to source some
file we presume is present in the environment. in this case hbase-env. it'd be
nice if we fixed that, but I don't think it needs to be your problem in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
