busbey commented on a change in pull request #1527: HBASE-24143 [JDK11] Switch
default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r410379376
##########
File path: bin/hbase
##########
@@ -136,6 +136,21 @@ if [ -f "$HBASE_HOME/conf/hbase-env-$COMMAND.sh" ]; then
. "$HBASE_HOME/conf/hbase-env-$COMMAND.sh"
fi
+# establish a default value for HBASE_OPTS if it's not already set. For now,
+# all we set is the garbage collector.
+if [ -z "${HBASE_OPTS}" ] ; then
+ major_version_number="$(parse_java_major_version "$(read_java_version)")"
+ case "$major_version_number" in
+ 8|9|10)
+ HBASE_OPTS="-XX:+UseConcMarkSweepGC"
+ ;;
+ 11|*)
+ HBASE_OPTS="-XX:+UseG1GC"
Review comment:
I guess that would mean when a newer JDK release changes the default
collector we'll stick with the G1GC we currently know. That's consistent with
how we handled CMS before. Makes sense.
> I wonder if we should move GC selection into the GC_OPTS family of
variables.
That is a really good point I had not thought of. Probably?
Should we even be setting a collector for the CLIENT_GC_OPTS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
