ndimiduk commented on a change in pull request #1527: HBASE-24143 [JDK11]
Switch default garbage collector from CMS
URL: https://github.com/apache/hbase/pull/1527#discussion_r409815532
##########
File path: bin/hbase-config.sh
##########
@@ -168,3 +168,27 @@ if [ -z "$JAVA_HOME" ]; then
EOF
exit 1
fi
+
+function read_java_version() {
+ properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
+ #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
Review comment:
Oh really?
I think there's more to it than that. I added on this patch but I still get
the SC2016 warning.
```
modified bin/hbase-config.sh
@@ -130,6 +130,7 @@ fi
# Source the hbase-env.sh. Will have JAVA_HOME defined.
# HBASE-7817 - Source the hbase-env.sh only if it has not already been
done. HBASE_ENV_INIT keeps track of it.
if [ -z "$HBASE_ENV_INIT" ] && [ -f "${HBASE_CONF_DIR}/hbase-env.sh" ]; then
+ # shellcheck source=../conf/hbase-env.sh
. "${HBASE_CONF_DIR}/hbase-env.sh"
export HBASE_ENV_INIT="true"
fi
@@ -171,7 +172,6 @@ fi
function read_java_version() {
properties="$("${JAVA_HOME}/bin/java" -XshowSettings:properties -version
2>&1)"
- #shellcheck disable=SC2016 # shellcheck cannot see through "${AWK}"
echo "${properties}" | "${GREP}" java.runtime.version | head -1 |
"${AWK}" 'BEGIN {FS = " = "} ; {print $NF}'
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
