virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422315817



##########
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##########
@@ -163,7 +164,16 @@ public void 
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
       assertNotEquals("Timeout waiting for server manager to become 
available.",
         -1, Waiter.waitFor(htu.getConfiguration(), timeout,
           () -> masterThread.getMaster().getServerManager() != null));
-      htu.getConnection().getAdmin().shutdown();
+      try {
+        htu.getConnection().getAdmin().shutdown();

Review comment:
       This is what I thought that after waitFor(), bootstrap should be over 
but in 2/50 cases, this stacktrace comes. This test is also present in flaky 
report and I just realized that flaky results data accessible is 2 days after 
Duo's commit. Let me check 5-10 older builds before the commit and see if this 
was not flaky before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to