[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted

[GitBox]

virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422318551



##########
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##########
@@ -163,7 +164,16 @@ public void 
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
       assertNotEquals("Timeout waiting for server manager to become 
available.",
         -1, Waiter.waitFor(htu.getConfiguration(), timeout,
           () -> masterThread.getMaster().getServerManager() != null));
-      htu.getConnection().getAdmin().shutdown();
+      try {
+        htu.getConnection().getAdmin().shutdown();

Review comment:
       Test results before 5th May doesn't seem available and the flakes seem 
present on the day of commit (need to check timezone diff): 
https://builds.apache.org/job/HBase-Flaky-Tests/job/master/6184/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org